[add] DisallowBearerToken option to operator to disallow bearer = true #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiashanel
added a commit
to nats-io/nsc
that referenced
this pull request
Apr 29, 2022
change 2 out of 3 for nats-io/nats-server#3084 corresponds to nats-io/jwt#177 also fixed minor staticcheck issues Signed-off-by: Matthias Hanel <mh@synadia.com>
matthiashanel
added a commit
to nats-io/nats-server
that referenced
this pull request
Apr 29, 2022
change 3 out of 3 for #3084 corresponds to: nats-io/jwt#177 nats-io/nsc#495 Signed-off-by: Matthias Hanel <mh@synadia.com>
matthiashanel
added a commit
to nats-io/nsc
that referenced
this pull request
Apr 29, 2022
change 2 out of 3 for nats-io/nats-server#3084 corresponds to nats-io/jwt#177 also fixed minor staticcheck issues Signed-off-by: Matthias Hanel <mh@synadia.com>
matthiashanel
added a commit
to nats-io/nats-server
that referenced
this pull request
Apr 29, 2022
I modified an existing data structure that held a similar attribute already. Instead this data structure references the claim. change 3 out of 3. Fixes #3084 corresponds to: nats-io/jwt#177 nats-io/nsc#495 Signed-off-by: Matthias Hanel <mh@synadia.com>
|
@matthiashanel not quite sure why this option is at the operator level - would seem that the bearer token could be enabled as a server config option which disables the feature server-wide. The bigger question is shouldn't this be an account-level option - since accounts issue users, seems reasonable that this would be the config where they can bounce them all? Perhaps both features would be useful. |
aricart
approved these changes
May 2, 2022
Signed-off-by: Matthias Hanel <mh@synadia.com>
matthiashanel
force-pushed
the
DisallowBearerToken
branch
from
7544ab4
to
b7cabf8
Compare
|
LGTM! |
matthiashanel
added a commit
to nats-io/nsc
that referenced
this pull request
May 9, 2022
* [added] support for account option DisallowBearerToken change 2 out of 3 for nats-io/nats-server#3084 corresponds to nats-io/jwt#177 also fixed minor staticcheck issues also removed unused ha_assets Signed-off-by: Matthias Hanel <mh@synadia.com>
matthiashanel
added a commit
to nats-io/nats-server
that referenced
this pull request
May 16, 2022
change 3 out of 3. Fixes #3084 corresponds to: nats-io/jwt#177 nats-io/nsc#495 Signed-off-by: Matthias Hanel <mh@synadia.com>
matthiashanel
added a commit
to nats-io/nats-server
that referenced
this pull request
Jun 13, 2022
change 3 out of 3. Fixes #3084 corresponds to: nats-io/jwt#177 nats-io/nsc#495 Signed-off-by: Matthias Hanel <mh@synadia.com>
matthiashanel
added a commit
to nats-io/nats-server
that referenced
this pull request
Jun 28, 2022
change 3 out of 3. Fixes #3084 corresponds to: nats-io/jwt#177 nats-io/nsc#495 Signed-off-by: Matthias Hanel <mh@synadia.com>
matthiashanel
added a commit
to nats-io/nats-server
that referenced
this pull request
Jun 29, 2022
* [added] support for jwt account option DisallowBearer change 3 out of 3. Fixes #3084 corresponds to: nats-io/jwt#177 nats-io/nsc#495 update jwt library to 2.3.0 Signed-off-by: Matthias Hanel <mh@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change 1 out of 3 for nats-io/nats-server#3084